Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dep for stcal to released version #8706

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 14, 2024

stcal 1.8.0 was released. We can now go back to using the released version (instead of installing from main). This PR updates the required version to >=1.8.0, <1.9.0. This range will allow installing the "dev" version which will appear as stcal-1.8.1.dev... when a new commit is added to stcal.

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1646/

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review August 14, 2024 15:22
@braingram braingram requested a review from a team as a code owner August 14, 2024 15:22
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (aeb7469) to head (e4ee465).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8706      +/-   ##
==========================================
+ Coverage   60.36%   60.38%   +0.01%     
==========================================
  Files         372      372              
  Lines       38338    38337       -1     
==========================================
+ Hits        23142    23148       +6     
+ Misses      15196    15189       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator Author

The regression tests show 9 failures. All related to miri and likely explained by the CRDS update which mentions:

The pipeline developers plan to remove the parameters nhigh and nlow from the outlier detection code, but they first need to be removed from the parameter reference files. This delivery of MIRI outlier detection parameter reference files removes the parameters nhigh and nlow from the reference files. The values of scale are also being updated to 1.0 0.8 from the previous values of 0.5 0.4, as this gave better results when tested on MIRI calibration data. This change will affect MIRI imager, coronagraphic and LRS slit data.

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like some of the failures were also due to updates in context 1259 - new photom files for MRS, which is ahead of the current operational context. I learned (or re-learned...) that our tests will use the latest context, regardless of which is set to operational.

@tapastro tapastro merged commit 1a45e34 into spacetelescope:master Aug 14, 2024
29 checks passed
@braingram braingram deleted the stcal_dep branch August 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants