Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-169] add user input to specify CRDS_CONTEXT #8702

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Aug 12, 2024

Resolves SCSB-169

image

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Aug 12, 2024
@github-actions github-actions bot added testing automation Continuous Integration (CI) and testing automation tools labels Aug 12, 2024
@zacharyburnett zacharyburnett added this to the Build 11.1 milestone Aug 12, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review August 12, 2024 15:08
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 12, 2024 15:08
@zacharyburnett zacharyburnett force-pushed the scsb169 branch 2 times, most recently from dd1a3d4 to 8a49f79 Compare August 12, 2024 15:15
@zacharyburnett zacharyburnett changed the title [CI] add user input to specify CRDS_CONTEXT [SCSB-169] add user input to specify CRDS_CONTEXT Aug 12, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review August 12, 2024 15:31
@zacharyburnett zacharyburnett enabled auto-merge (squash) August 12, 2024 15:58
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (f6c4095) to head (204dc8c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8702   +/-   ##
=======================================
  Coverage   60.38%   60.38%           
=======================================
  Files         372      372           
  Lines       38337    38337           
=======================================
  Hits        23148    23148           
  Misses      15189    15189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Once this is merged it would be helpful to trigger the ci ci_cron and tests_devdeps jobs to make sure they work work with a defined context.

@zacharyburnett zacharyburnett merged commit a232ef9 into spacetelescope:master Aug 12, 2024
29 checks passed
@braingram
Copy link
Collaborator

All jobs picked up the 1255 context. I'm not sure why the oldestdeps just reported "This job failed" https://github.com/spacetelescope/jwst/actions/runs/10357731826/job/28670412829

@zacharyburnett zacharyburnett deleted the scsb169 branch August 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants