Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't build for python 3.13 #8691

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 6, 2024

cibuildwheel is now (attempting) to build for python 3.13.

However our dependencies (and likely code) is not yet ready.

This is currently leading to build failures due to an attempt to build scipy from source.

This PR restricts the build job to only build for python 3.10, 3.11 and 3.12 (the listed supported versions in pyproject.toml).

Closes #8690

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@github-actions github-actions bot added the automation Continuous Integration (CI) and testing automation tools label Aug 6, 2024
@braingram braingram marked this pull request as ready for review August 6, 2024 17:32
@braingram braingram requested a review from a team as a code owner August 6, 2024 17:32
@braingram braingram requested review from zacharyburnett and removed request for a team August 6, 2024 17:33
@zacharyburnett
Copy link
Collaborator

wow, a magic cibuildwheel pattern!

@braingram
Copy link
Collaborator Author

fnmatch FTW!

Note that the same pattern will not work for any library still supporting python 3.9.

@braingram braingram enabled auto-merge August 6, 2024 18:07
@braingram braingram merged commit 89f126a into spacetelescope:master Aug 6, 2024
23 checks passed
@braingram braingram deleted the cibw_py313 branch August 6, 2024 18:16
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (7a95556) to head (f6c4095).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8691   +/-   ##
=======================================
  Coverage   60.38%   60.38%           
=======================================
  Files         372      372           
  Lines       38337    38337           
=======================================
  Hits        23148    23148           
  Misses      15189    15189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cibuildwheel fails for python 3.13
2 participants