JP-3636: Fix crash in tweakreg due to MalformedPolygonError #8657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8657 +/- ##
==========================================
- Coverage 60.23% 60.21% -0.02%
==========================================
Files 370 370
Lines 38636 38630 -6
==========================================
- Hits 23272 23261 -11
- Misses 15364 15369 +5 ☔ View full report in Codecov by Sentry. |
nden
reviewed
Jul 18, 2024
CHANGES.rst
Outdated
| in the ``tweakreg`` step due to a ``MalformedPolygonError`` exception being | ||
| raised by the ``spherical_geometry`` package for some data sets. For more | ||
| details, see JP-3636 and | ||
| https://github.com/spacetelescope/tweakwcs/pull/205. [#8657] |
There was a problem hiding this comment.
This is also user facing documentation and we don't keep references to JP. here. Can you replace the last sentence with
Fix is in spacetelescope/tweakwcs#205.
nden
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3636
Closes #8513
This PR fixes a crash in the
tweakregstep due toMalformedPolygonErrorin thespherical_geometry. The error was fixed via spacetelescope/tweakwcs#205Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionRegression test was run here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1608