-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3687: fix outlier_detection failures when run outside pipeline #8645
Conversation
Regression tests started here, using the new GitHub Actions workflow (hope that works!) https://github.com/spacetelescope/RegressionTests/actions/runs/9940607341 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8645 +/- ##
=======================================
Coverage 59.60% 59.61%
=======================================
Files 391 391
Lines 39286 39287 +1
=======================================
+ Hits 23418 23419 +1
Misses 15868 15868 ☔ View full report in Codecov by Sentry. |
separate regtests with same changes started here on Jenkins: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1605/ |
all regtest failures are unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small comment grammar suggestion.
Co-authored-by: Melanie Clarke <[email protected]>
Resolves JP-3687
Closes #8640
This PR addresses a bug that occurs when the
outlier_detection
step is run outside the pipeline, i.e., loading the datamodel from file instead of passing it in as aModelContainer
. In that case, thewcs.array_shape
attribute sometimes does not get saved (saving of this attribute was added to gwcs within the past year, so the behavior is version-dependent). This PR sets thewcs.array_shape
explicitly.Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR