Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3687: fix outlier_detection failures when run outside pipeline #8645

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Jul 15, 2024

Resolves JP-3687

Closes #8640

This PR addresses a bug that occurs when the outlier_detection step is run outside the pipeline, i.e., loading the datamodel from file instead of passing it in as a ModelContainer. In that case, the wcs.array_shape attribute sometimes does not get saved (saving of this attribute was added to gwcs within the past year, so the behavior is version-dependent). This PR sets the wcs.array_shape explicitly.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@emolter
Copy link
Collaborator Author

emolter commented Jul 15, 2024

Regression tests started here, using the new GitHub Actions workflow (hope that works!) https://github.com/spacetelescope/RegressionTests/actions/runs/9940607341

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.61%. Comparing base (4b77a5e) to head (d433757).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8645   +/-   ##
=======================================
  Coverage   59.60%   59.61%           
=======================================
  Files         391      391           
  Lines       39286    39287    +1     
=======================================
+ Hits        23418    23419    +1     
  Misses      15868    15868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Collaborator Author

emolter commented Jul 15, 2024

separate regtests with same changes started here on Jenkins: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1605/

@emolter
Copy link
Collaborator Author

emolter commented Jul 15, 2024

all regtest failures are unrelated

@emolter emolter marked this pull request as ready for review July 15, 2024 20:44
@emolter emolter requested a review from a team as a code owner July 15, 2024 20:44
@emolter emolter added this to the Build 11.1 milestone Jul 15, 2024
@emolter emolter requested a review from melanieclarke July 15, 2024 20:45
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment grammar suggestion.

@emolter emolter merged commit 8af184c into spacetelescope:master Jul 16, 2024
27 checks passed
@emolter emolter deleted the JP-3687 branch July 16, 2024 12:46
braingram added a commit to braingram/jwst that referenced this pull request Jul 18, 2024
braingram added a commit to braingram/jwst that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outlier detection fails due to missing array_shape when run outside pipeline
2 participants