-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTD: Clear the dirty git index flag #8644
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8644 +/- ##
==========================================
- Coverage 59.61% 59.60% -0.01%
==========================================
Files 391 391
Lines 39287 39280 -7
==========================================
- Hits 23419 23412 -7
Misses 15868 15868 ☔ View full report in Codecov by Sentry. |
Yes, this is expected. This is my local test case:
Note: We marked the local
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves JP-nnnn
Closes #
The last build (#8642) produced:
RTD modifies indexed files in the repository prior to building the documentation. This change should prevent
setuptools_scm
from returning a dirty version (.dXXXXXXXX
suffix).See: https://docs.readthedocs.io/en/stable/build-customization.html#avoid-having-a-dirty-git-index
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR