-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate nlow nhigh, fix incorrect spec values in docs #8603
Merged
hbushouse
merged 6 commits into
spacetelescope:master
from
braingram:deprecate_nlow_nhigh
Jun 26, 2024
Merged
deprecate nlow nhigh, fix incorrect spec values in docs #8603
hbushouse
merged 6 commits into
spacetelescope:master
from
braingram:deprecate_nlow_nhigh
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8603 +/- ##
==========================================
+ Coverage 59.54% 59.56% +0.02%
==========================================
Files 391 391
Lines 39292 39285 -7
==========================================
+ Hits 23396 23402 +6
+ Misses 15896 15883 -13 ☔ View full report in Codecov by Sentry. |
hbushouse
reviewed
Jun 26, 2024
Co-authored-by: Howard Bushouse <[email protected]>
c402d27
to
56ad26c
Compare
hbushouse
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final (I hope) comment.
braingram
commented
Jun 26, 2024
hbushouse
reviewed
Jun 26, 2024
hbushouse
approved these changes
Jun 26, 2024
hbushouse
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8602 and:
The spec values in the docs do not match the step (see the below linked issue). This PR removes the datatypes and defaults from the "arguments" docs page and adds a link to the spec (which will automatically stay up-to-date with the step).
Link to the updated docs: https://jwst-pipeline--8603.org.readthedocs.build/en/8603/jwst/outlier_detection/arguments.html
Fixes #8599
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR