Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3631: remove direct setting of self.skip within calibration steps #8600

Merged
merged 12 commits into from
Jul 10, 2024

responding to @melanieclarke comments

4f603fb
Select commit
Loading
Failed to load commit list.
Merged

JP-3631: remove direct setting of self.skip within calibration steps #8600

responding to @melanieclarke comments
4f603fb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jun 28, 2024 in 0s

69.49% of diff hit (target 59.56%)

View this Pull Request on Codecov

69.49% of diff hit (target 59.56%)

Annotations

Check warning on line 399 in jwst/cube_build/cube_build_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/cube_build/cube_build_step.py#L399

Added line #L399 was not covered by tests

Check warning on line 112 in jwst/master_background/master_background_mos_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_mos_step.py#L112

Added line #L112 was not covered by tests

Check warning on line 127 in jwst/master_background/master_background_mos_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_mos_step.py#L127

Added line #L127 was not covered by tests

Check warning on line 131 in jwst/master_background/master_background_mos_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_mos_step.py#L131

Added line #L131 was not covered by tests

Check warning on line 140 in jwst/master_background/master_background_mos_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_mos_step.py#L140

Added line #L140 was not covered by tests

Check warning on line 147 in jwst/master_background/master_background_mos_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_mos_step.py#L147

Added line #L147 was not covered by tests

Check warning on line 82 in jwst/master_background/master_background_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_step.py#L82

Added line #L82 was not covered by tests

Check warning on line 163 in jwst/master_background/master_background_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/master_background/master_background_step.py#L163

Added line #L163 was not covered by tests

Check warning on line 152 in jwst/pipeline/calwebb_spec3.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/pipeline/calwebb_spec3.py#L152

Added line #L152 was not covered by tests

Check warning on line 111 in jwst/pixel_replace/pixel_replace_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/pixel_replace/pixel_replace_step.py#L111

Added line #L111 was not covered by tests

Check warning on line 203 in jwst/stpipe/utilities.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/stpipe/utilities.py#L203

Added line #L203 was not covered by tests

Check warning on line 209 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L208-L209

Added lines #L208 - L209 were not covered by tests

Check warning on line 313 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L313

Added line #L313 was not covered by tests

Check warning on line 329 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L329

Added line #L329 was not covered by tests

Check warning on line 339 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L339

Added line #L339 was not covered by tests

Check warning on line 457 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L457

Added line #L457 was not covered by tests

Check warning on line 476 in jwst/tweakreg/tweakreg_step.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

jwst/tweakreg/tweakreg_step.py#L476

Added line #L476 was not covered by tests