Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3643: Add background error propagation for non-IFU spectral extraction #8532

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

ianyuwong
Copy link
Contributor

@ianyuwong ianyuwong commented May 31, 2024

Resolves JP-3643

Closes #8522

This PR adds background error propagation when subtracting the background during non-IFU spectral extraction by adding the Poisson/read noise/flat variance contributions from the background to the corresponding arrays from the source extraction region.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@ianyuwong ianyuwong requested a review from a team as a code owner May 31, 2024 22:26
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.02%. Comparing base (4179c09) to head (84e65e6).
Report is 321 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8532      +/-   ##
==========================================
+ Coverage   57.97%   58.02%   +0.05%     
==========================================
  Files         387      388       +1     
  Lines       38830    38982     +152     
==========================================
+ Hits        22513    22621     +108     
- Misses      16317    16361      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone Jun 5, 2024
@hbushouse
Copy link
Collaborator

@hbushouse
Copy link
Collaborator

Regression tests showed expected changes in error columns in x1d/x1dints products, and a bunch of unrelated changes due to a MIRI ref file update. So this looks good.

@hbushouse hbushouse merged commit f2c9e93 into spacetelescope:master Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background error propagation in non-IFU background subtraction
2 participants