JP-3625: Switch to IRAF starfinder default

[drlaw1558]

Resolves JP-3625 by switching the code default starfinder for use in tweakreg to IRAF starfinder instead of DAO starfinder.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• All comments are resolved
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (781e0e0) to head (2073da0).
Report is 294 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8487      +/-   ##
==========================================
+ Coverage   57.93%   58.00%   +0.06%     
==========================================
  Files         387      387              
  Lines       38839    38811      -28     
==========================================
+ Hits        22502    22512      +10     
+ Misses      16337    16299      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emolter]

Looks good David, thanks! Would you please also change the default of the make_tweakreg_catalog function here, for clarity?

It would also be good to run a regression test, as it's certainly possible this change would have a small effect on the solution coming from tweakreg.

[drlaw1558]

Looks good David, thanks! Would you please also change the default of the make_tweakreg_catalog function here, for clarity?

It would also be good to run a regression test, as it's certainly possible this change would have a small effect on the solution coming from tweakreg.

Done! Not sure how to set off regression tests though.

[hbushouse]

Started regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1458

[hbushouse]

Regtest run shows small, expected differences in level-3 imaging products, due to slight differences in tweakreg results. So I think this looks OK.