-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding tests for changes in JP-3311 and minor fixes #8481
Conversation
running reg test at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1438/ -> cancelled |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8481 +/- ##
==========================================
- Coverage 57.93% 57.93% -0.01%
==========================================
Files 387 387
Lines 38839 38852 +13
==========================================
+ Hits 22502 22508 +6
- Misses 16337 16344 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me! Can you run a new regtest on Jenkins, at least for the tests that were previously failing (test_miri_lrs_slit_spec3 and test_nirspec_fs_spec3)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes seem fine to me and latest regtest run showed only 1 unrelated failure. So I think this is good to go.
Resolves JP-3311
Closes #
This PR adds tests for changes made in https://github.com/spacetelescope/jwst/pull/8464
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR