Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tests for changes in JP-3311 and minor fixes #8481

Merged
merged 6 commits into from
May 17, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented May 13, 2024

Resolves JP-3311

Closes #

This PR adds tests for changes made in https://github.com/spacetelescope/jwst/pull/8464

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@penaguerrero
Copy link
Contributor Author

penaguerrero commented May 13, 2024

@penaguerrero
Copy link
Contributor Author

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.93%. Comparing base (781e0e0) to head (1a54d02).
Report is 294 commits behind head on master.

Files Patch % Lines
jwst/outlier_detection/outlier_detection_spec.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8481      +/-   ##
==========================================
- Coverage   57.93%   57.93%   -0.01%     
==========================================
  Files         387      387              
  Lines       38839    38852      +13     
==========================================
+ Hits        22502    22508       +6     
- Misses      16337    16344       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me! Can you run a new regtest on Jenkins, at least for the tests that were previously failing (test_miri_lrs_slit_spec3 and test_nirspec_fs_spec3)?

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine to me and latest regtest run showed only 1 unrelated failure. So I think this is good to go.

@hbushouse hbushouse merged commit 4d4f935 into spacetelescope:master May 17, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants