limit rotation test to 10x the angular repeatability #8456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jwst/assign_wcs/tests/test_niriss.py::test_filter_rotation
test is failing on main with the new CRDS context (1228).The new context contains updated
specwcs
reference files which are leading to the test failure when a 20 degree "rotation" is tested. This appears to be the rotation of the filter (relative to the reference position). A 20 degree rotation seems unlikely given the wheel has a quoted repeatability of 0.1585 degrees (taken from: https://jwst-docs.stsci.edu/jwst-near-infrared-imager-and-slitless-spectrograph/niriss-instrumentation/niriss-pupil-and-filter-wheels#gsc.tab=0).The test was updated to instead test a rotation that is 10x the quoted repeatability.
However, this test failure may point to other issues with the niriss wcs transforms (which I am not familiar with). @nden does this test update look reasonable to you?
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR