Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit rotation test to 10x the angular repeatability #8456

Merged
merged 1 commit into from
May 2, 2024

Conversation

braingram
Copy link
Collaborator

The jwst/assign_wcs/tests/test_niriss.py::test_filter_rotation test is failing on main with the new CRDS context (1228).

The new context contains updated specwcs reference files which are leading to the test failure when a 20 degree "rotation" is tested. This appears to be the rotation of the filter (relative to the reference position). A 20 degree rotation seems unlikely given the wheel has a quoted repeatability of 0.1585 degrees (taken from: https://jwst-docs.stsci.edu/jwst-near-infrared-imager-and-slitless-spectrograph/niriss-instrumentation/niriss-pupil-and-filter-wheels#gsc.tab=0).

The test was updated to instead test a rotation that is 10x the quoted repeatability.

However, this test failure may point to other issues with the niriss wcs transforms (which I am not familiar with). @nden does this test update look reasonable to you?

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (17e0cd9) to head (c084e0b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8456   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         387      387           
  Lines       38716    38716           
=======================================
  Hits        21830    21830           
  Misses      16886    16886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@nden nden merged commit 7934084 into spacetelescope:master May 2, 2024
28 of 29 checks passed
@braingram braingram deleted the filter_rotation branch May 2, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants