-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow ami_analyze step to run on cal files #8451
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8451 +/- ##
==========================================
+ Coverage 56.38% 56.45% +0.07%
==========================================
Files 387 387
Lines 38716 38774 +58
==========================================
+ Hits 21830 21891 +61
+ Misses 16886 16883 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification looks good, I examined the outputs of the new regtest for 2D files and didn't notice anything obviously amiss. Thanks for doing this!
4e1c9d0
to
aa7d858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This allows
ami_analyze
to run on cal files. A regression test is added (input and truth files will be added and a run started when the files are approved).This is an alternative to #8448 and instead of using the generic
DataModel
converts the inputImageModel
to aCubeModel
before the dimension expansion.Regression tests run at:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1411/
Showed 1 unrelated error in
[stable-deps] test_filter_rotation – jwst.assign_wcs.tests.test_niriss
which is also failing on main:https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2869/testReport/junit/jwst.assign_wcs.tests/test_niriss/_stable_deps__test_filter_rotation/
The regtest added in this PR passed.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR