JP-3606: Outlier detection cleanup #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8438 +/- ##
===========================================
- Coverage 75.31% 56.38% -18.93%
===========================================
Files 474 387 -87
Lines 38965 38716 -249
===========================================
- Hits 29345 21830 -7515
- Misses 9620 16886 +7266
☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
outlier_detection_cleanup
branch
from
1df8abc to
cab6c2f
Compare
braingram
changed the title
|
@braingram This looks good to me. Feel free to merge if ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unused code from
outlier_detection.This PR removes the unused:
OutlierDetectionScaledStep,OutlierDetectionStackStepoutlierparsreference file handling,scale_detectionfromOutlierDetectinStepspecscale_detectionfromcalwebb_tso3Regtests show 4 unrelated failures
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1406/
3 are the "usual suspects" that fail intermittently due to logging issue (test_duplicate_names, test_nirspec_missing_msa_fail, and test_nirspec_missing_msa_nofail).
test_miri_image_detector1_with_avg_dark_current[rate]also failed but in the same way as it's failing on main:https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2866/testReport/junit/jwst.regtest/test_miri_image/_stable_deps__test_miri_image_detector1_with_avg_dark_current_rate_/
Resolves JP-3606
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR