Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 8305 #8419

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Revert 8305 #8419

merged 3 commits into from
Apr 11, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Apr 10, 2024

This PR reverts #8305

Further testing revealed that issues reported in JP-2943 persisted after the attempted fix in #8305

Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1391/

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review April 10, 2024 22:10
@braingram braingram requested a review from a team as a code owner April 10, 2024 22:10
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (2fb073e) to head (ed2e44d).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8419      +/-   ##
==========================================
+ Coverage   75.31%   75.78%   +0.47%     
==========================================
  Files         474      476       +2     
  Lines       38965    39424     +459     
==========================================
+ Hits        29345    29877     +532     
+ Misses       9620     9547      -73     
Flag Coverage Δ *Carryforward flag
nightly 77.66% <100.00%> (+0.32%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 11, 2024
@hbushouse hbushouse merged commit f5e01e9 into spacetelescope:master Apr 11, 2024
28 checks passed
@braingram braingram deleted the revert_8305 branch April 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants