Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3518: Match imprint and science association members by mosaic and dither position #8410

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Apr 3, 2024

Resolves JP-3518

Closes #8215

This PR addresses mismatches between NIRSpec science and imprint members in level2 spectral associations.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro requested a review from a team as a code owner April 3, 2024 17:30
@tapastro tapastro marked this pull request as draft April 3, 2024 17:30
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (2fb073e) to head (0abd5fa).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8410      +/-   ##
==========================================
+ Coverage   75.31%   75.78%   +0.47%     
==========================================
  Files         474      476       +2     
  Lines       38965    39450     +485     
==========================================
+ Hits        29345    29897     +552     
+ Misses       9620     9553      -67     
Flag Coverage Δ *Carryforward flag
nightly 77.65% <ø> (+0.31%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tapastro tapastro force-pushed the jp-3116-bkgd-ctype-asns branch from 656b370 to 0abd5fa Compare April 5, 2024 14:43
@tapastro tapastro added this to the Build 11.0 milestone Apr 5, 2024
@hbushouse
Copy link
Collaborator

@tapastro Is this ready for review? If so, can you un-draft it?

@tapastro
Copy link
Contributor Author

tapastro commented Apr 5, 2024

Apologies, meant to un-draft this after our planning meeting but it ran into my departure for a doctor's appt.

Regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1374/

The new pool I added is an expected failure, but results have been verified locally.

@tapastro tapastro marked this pull request as ready for review April 5, 2024 19:18
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, regtests look good.

@hbushouse hbushouse merged commit ccdb12d into spacetelescope:master Apr 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in matching the NIRSpec Imprint image to the Science image for Mosaic IFU data
2 participants