-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3518: Match imprint and science association members by mosaic and dither position #8410
JP-3518: Match imprint and science association members by mosaic and dither position #8410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8410 +/- ##
==========================================
+ Coverage 75.31% 75.78% +0.47%
==========================================
Files 474 476 +2
Lines 38965 39450 +485
==========================================
+ Hits 29345 29897 +552
+ Misses 9620 9553 -67
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
656b370
to
0abd5fa
Compare
@tapastro Is this ready for review? If so, can you un-draft it? |
Apologies, meant to un-draft this after our planning meeting but it ran into my departure for a doctor's appt. Regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1374/ The new pool I added is an expected failure, but results have been verified locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, regtests look good.
Resolves JP-3518
Closes #8215
This PR addresses mismatches between NIRSpec science and imprint members in level2 spectral associations.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR