Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3554: Add MSA meta data file docs #8399

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Apr 1, 2024

Resolves JP-3554

Closes #8314

This PR adds detailed docs for the contents and usage of the NIRSpec MSA metadata file, which is used during Spec2 processing of NRS MOS exposures. In addition to a new page describing the MSA metadata file itself, I've also added some updates to the assign_wcs step docs that reference the MSA metadata file and just make a few minor updates/fixes to the assign_wcs docs themselves.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 1, 2024
@hbushouse hbushouse requested a review from a team as a code owner April 1, 2024 12:29
@hbushouse
Copy link
Collaborator Author

@hbushouse hbushouse requested review from nden and emolter April 1, 2024 12:47
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (2fb073e) to head (17abdb4).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8399      +/-   ##
==========================================
+ Coverage   75.31%   75.77%   +0.46%     
==========================================
  Files         474      476       +2     
  Lines       38965    39442     +477     
==========================================
+ Hits        29345    29887     +542     
+ Misses       9620     9555      -65     
Flag Coverage Δ *Carryforward flag
nightly 77.63% <ø> (+0.29%) ⬆️ Carriedforward from 1d8f0fe

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse requested a review from emolter April 2, 2024 11:54
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit d6b3e38 into spacetelescope:master Apr 2, 2024
27 of 28 checks passed
@hbushouse hbushouse deleted the jp-3554 branch April 2, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation of MSA metafile to Readthedocs
2 participants