fix issues flagged by SonarQube

[zacharyburnett]

closes #8390

This PR addresses issues flagged by SonarQube (https://plsonarqube.stsci.edu/project/issues?resolved=false&inNewCodePeriod=true&types=BUG&id=jwst&open=AY54FDbH6KYUncGRZ448)

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[zacharyburnett]

regtest running at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1354/pipeline https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1355/pipeline

[zacharyburnett]

SonarScan also found some issues here: #8390

[zacharyburnett]

regtests at 90% with no failures

[braingram]

Thanks for opening the PR. As all the changes are in the new niriss AMI code and haven't so far triggered errors (which they should given the types of errors) I expect they are uncovered. Indeed I see no call to fit_image. EDIT fit_image is called. I missed

jwst/jwst/ami/nrm_core.py

Line 227 in ec0f0ed

nrm.fit_image(self.ctrd,

@rcooper295 is NrmModel.fit_image ever used without providing modelin?

jwst/jwst/ami/lg_model.py

Line 292 in ec0f0ed

def fit_image(

If not I'd say we remove the method block of code.

Also the regtests will need to be run against CRDS-TEST to test the AMI code until ops is updated. It looks like the current run is using ops so the AMI tests are expected to fail.

[braingram]

I ran the AMI regtests and unit tests with this branch locally (with a cache of CRDS-TEST files). The ami regtests pass with these changes.

Perhaps a follow-up issue should be opened to track the wider code cleanup with input from @rcooper295?