-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3585: remove deprecated datamodel types #8388
Conversation
The corresponding stdatamodels changes have been merged into Anything I can do to help bring this out of draft? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8388 +/- ##
==========================================
+ Coverage 75.31% 75.78% +0.47%
==========================================
Files 474 476 +2
Lines 38965 39450 +485
==========================================
+ Hits 29345 29896 +551
+ Misses 9620 9554 -66
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I just added the changelog entry and moved it out of draft. It would be helpful if you could review it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Assuming the regtests don't reveal any surprises this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures in regtest run are unrelated. Everything looks good here.
Resolves JP-3585
Closes #8382
This PR enforces removal of the deprecated stdatamodels model types DrizProductModel, MIRIRampModel, and MultiProductModel. Most of the changes are in stdatamodels; see PR here. On the jwst side, the only change is to remove the model types from the deprecated list.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR