Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3585: remove deprecated datamodel types #8388

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Mar 25, 2024

Resolves JP-3585

Closes #8382

This PR enforces removal of the deprecated stdatamodels model types DrizProductModel, MIRIRampModel, and MultiProductModel. Most of the changes are in stdatamodels; see PR here. On the jwst side, the only change is to remove the model types from the deprecated list.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram
Copy link
Collaborator

The corresponding stdatamodels changes have been merged into main: spacetelescope/stdatamodels#171

Anything I can do to help bring this out of draft?

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (2fb073e) to head (b4de8c3).
Report is 25 commits behind head on master.

❗ Current head b4de8c3 differs from pull request most recent head bb9fa07. Consider uploading reports for the commit bb9fa07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8388      +/-   ##
==========================================
+ Coverage   75.31%   75.78%   +0.47%     
==========================================
  Files         474      476       +2     
  Lines       38965    39450     +485     
==========================================
+ Hits        29345    29896     +551     
+ Misses       9620     9554      -66     
Flag Coverage Δ *Carryforward flag
nightly 77.65% <ø> (+0.31%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review April 5, 2024 20:31
@emolter emolter requested a review from a team as a code owner April 5, 2024 20:31
@emolter
Copy link
Collaborator Author

emolter commented Apr 5, 2024

The corresponding stdatamodels changes have been merged into main: spacetelescope/stdatamodels#171

Anything I can do to help bring this out of draft?

I just added the changelog entry and moved it out of draft. It would be helpful if you could review it!
Regression tests started here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

Assuming the regtests don't reveal any surprises this looks good to me.

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 10, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures in regtest run are unrelated. Everything looks good here.

@hbushouse hbushouse merged commit 14c8177 into spacetelescope:master Apr 10, 2024
23 checks passed
@emolter emolter deleted the JP-3585 branch April 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove long-deprecated unused datamodels
3 participants