-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3494: write tweakreg source catalogs into user-specified output_dir #8386
Conversation
started regression tests here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8386 +/- ##
==========================================
+ Coverage 75.31% 75.67% +0.36%
==========================================
Files 474 476 +2
Lines 38965 39439 +474
==========================================
+ Hits 29345 29845 +500
+ Misses 9620 9594 -26
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could use another regtest run. The first one was messed up by dependencies not being synched up properly while in the midst of getting ready for the b10.2 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look good to me. Just holding final approval until there's a more recent regtest run to look at.
new regtest run started here |
Failures in latest regtest run are all benign and unrelated to this PR. |
Resolves JP-3494
Closes #8144
This PR addresses an issue where the
output_dir
parameter was not respected when writing source catalogs in thetweakreg
step.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR