Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3494: write tweakreg source catalogs into user-specified output_dir #8386

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Mar 25, 2024

Resolves JP-3494

Closes #8144

This PR addresses an issue where the output_dir parameter was not respected when writing source catalogs in the tweakreg step.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@emolter emolter changed the title JP-3494 JP-3494: write tweakreg source catalogs into user-specified output_dir Mar 25, 2024
@emolter
Copy link
Collaborator Author

emolter commented Mar 27, 2024

started regression tests here

@emolter emolter marked this pull request as ready for review March 28, 2024 13:05
@emolter emolter requested a review from a team as a code owner March 28, 2024 13:05
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.67%. Comparing base (2fb073e) to head (2c9854e).
Report is 21 commits behind head on master.

❗ Current head 2c9854e differs from pull request most recent head d310235. Consider uploading reports for the commit d310235 to get more accurate results

Files Patch % Lines
jwst/tweakreg/tweakreg_step.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8386      +/-   ##
==========================================
+ Coverage   75.31%   75.67%   +0.36%     
==========================================
  Files         474      476       +2     
  Lines       38965    39439     +474     
==========================================
+ Hits        29345    29845     +500     
+ Misses       9620     9594      -26     
Flag Coverage Δ *Carryforward flag
nightly 77.66% <ø> (+0.32%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 2, 2024
@hbushouse
Copy link
Collaborator

Could use another regtest run. The first one was messed up by dependencies not being synched up properly while in the midst of getting ready for the b10.2 release.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates look good to me. Just holding final approval until there's a more recent regtest run to look at.

@emolter
Copy link
Collaborator Author

emolter commented Apr 2, 2024

new regtest run started here

@hbushouse
Copy link
Collaborator

Failures in latest regtest run are all benign and unrelated to this PR.

@hbushouse hbushouse merged commit 804743f into spacetelescope:master Apr 2, 2024
22 of 23 checks passed
@emolter emolter deleted the JP-3494 branch January 29, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put output gaia catalog in specified directory
2 participants