Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in emicorr logic for finding matching ref file info #8375

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Mar 20, 2024

This PR addresses a bug in the emicorr step that was discovered after merging #8270. The bug affected the matching of dataset subarray and readpatt values to ref file entries, which was causing no matching entry to be found and hence the step was skipped.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner March 20, 2024 15:09
@penaguerrero
Copy link
Contributor Author

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.26%. Comparing base (2fb073e) to head (5ac1795).
Report is 4 commits behind head on master.

Files Patch % Lines
jwst/emicorr/emicorr.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8375      +/-   ##
==========================================
- Coverage   75.31%   75.26%   -0.05%     
==========================================
  Files         474      474              
  Lines       38965    38999      +34     
==========================================
+ Hits        29345    29354       +9     
- Misses       9620     9645      +25     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.01%) ⬇️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse changed the title fixing bug to find subarray config Fix bug in emicorr logic for finding matching ref file info Mar 20, 2024
@hbushouse hbushouse added this to the Build 10.2 milestone Mar 20, 2024
@hbushouse
Copy link
Collaborator

A bunch of regtest runs went south due to connection issues. I've restarted a test run for this PR at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1333

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression test runs are still having trouble on jwcalibdev. So I'm just going to merge this and test standalone (locally) using the latest jwst/master.

@hbushouse hbushouse merged commit 42f0e01 into spacetelescope:master Mar 21, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants