-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3574: fix stage 2 pipeline steps not respecting output_file parameter #8368
Conversation
regression test run started here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8368 +/- ##
==========================================
+ Coverage 75.31% 75.77% +0.46%
==========================================
Files 474 476 +2
Lines 38965 39442 +477
==========================================
+ Hits 29345 29887 +542
+ Misses 9620 9555 -65
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hopefully fixed regression test failures, new Jenkins run started here |
one more regtest attempt here edit: after problems with Jenkins were resolved, regtest run here. Regtest run had some failures in MIRI imaging that I believe were unrelated |
All failures in the last regtest run were benign. |
Resolves JP-3574
Closes #8354
This PR addresses a bug where the
spec2pipeline
andimage2pipeline
did not respect theoutput_file
parameter when it was set by the user. Small documentation updates also clarify that associations generally should not have multiple rate or rateints files in them.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR