Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3574: fix stage 2 pipeline steps not respecting output_file parameter #8368

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Mar 15, 2024

Resolves JP-3574

Closes #8354

This PR addresses a bug where the spec2pipeline and image2pipeline did not respect the output_file parameter when it was set by the user. Small documentation updates also clarify that associations generally should not have multiple rate or rateints files in them.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@emolter
Copy link
Collaborator Author

emolter commented Mar 15, 2024

regression test run started here

@emolter emolter marked this pull request as ready for review March 15, 2024 16:09
@emolter emolter requested a review from a team as a code owner March 15, 2024 16:09
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (2fb073e) to head (d3e4ae2).
Report is 18 commits behind head on master.

❗ Current head d3e4ae2 differs from pull request most recent head af6cbcf. Consider uploading reports for the commit af6cbcf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8368      +/-   ##
==========================================
+ Coverage   75.31%   75.77%   +0.46%     
==========================================
  Files         474      476       +2     
  Lines       38965    39442     +477     
==========================================
+ Hits        29345    29887     +542     
+ Misses       9620     9555      -65     
Flag Coverage Δ *Carryforward flag
nightly 77.63% <ø> (+0.29%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Collaborator Author

emolter commented Mar 19, 2024

Hopefully fixed regression test failures, new Jenkins run started here

@emolter
Copy link
Collaborator Author

emolter commented Mar 20, 2024

one more regtest attempt here

edit: after problems with Jenkins were resolved, regtest run here.

Regtest run had some failures in MIRI imaging that I believe were unrelated

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 1, 2024
@hbushouse
Copy link
Collaborator

All failures in the last regtest run were benign.

@hbushouse hbushouse merged commit 74bec99 into spacetelescope:master Apr 2, 2024
23 of 24 checks passed
@emolter emolter deleted the JP-3574 branch January 29, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stage 2 pipelines ignore output_file parameter
2 participants