-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-145] require Python 3.10 #8365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8365 +/- ##
==========================================
- Coverage 75.31% 75.19% -0.12%
==========================================
Files 474 474
Lines 38965 39003 +38
==========================================
- Hits 29345 29330 -15
- Misses 9620 9673 +53
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The "py39" CI tests apparently need to be removed, because it's no longer valid to test with 3.9? |
This should probably also update the README/Docs to change the listed minimum version allowed - the alternative is to change that once the next build is done, but that risks it being forgotten about. Best practices? |
Sorry for the oversights! I'm using this ticket to test making automated PRs with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also a bunch of references to Python 3.9 in the install.rst file that should be removed
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 16 should be removed; Python 3.9 should no longer be one of the classifiers
|
||
**Until Python 3.12 is supported, fresh conda environments will require setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually support py3.12 now (or will support it in the B10.2 release)? i.e. does everything actually work correctly now under 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if anyone has run the regtests with python 3.12. @zacharyburnett would changing the following be enough to convince jenkins to use python 3.12?
Line 46 in e1b0772
python_version = "3.11" |
The unit tests have been running with python 3.12:
https://github.com/spacetelescope/jwst/actions/runs/8345372313/job/22840164182
We have one open PR that is python 3.12 related (which addresses a DeprecationWarning
introduced in that version):
#8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that should be enough; I can make a separate PR with that I added Python 3.12 as a separate job in JenkinsfileRT
in 52a2a00 and am running it at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1329/pipeline/
fixed in a2fdc77 |
This reverts commit 749773b.
resolves SCSB-145
propagate Astropy's deprecation of Python 3.9 to downstream packages
Note
this PR was generated automatically by
batchpr
🤖