-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3445: Exclude NINTS=1 from SOSS TSO3 associations #8359
Conversation
Test results using the pool from program jw03596 show that the tso3 asn for observation 001 no longer contain the exposure "jw03596001001_03101_00001-seg001_nis_calints.fits", which is the "dummy" exposure that uses NINTS=1 and was causing the tso3 pipeline to abort. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8359 +/- ##
==========================================
+ Coverage 75.15% 75.31% +0.15%
==========================================
Files 470 474 +4
Lines 38604 38965 +361
==========================================
+ Hits 29014 29346 +332
- Misses 9590 9619 +29
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1315 Note that a new pool and related output asn files have been added to the asn regression tests on Artifactory. The new pool comes from the 3596 program that was causing the original trouble. It contains the additional "NINTS" column that SDP will now be adding to all pool files. |
All 53 regression test failures are unrelated and due to a recent update to a datamodels schema. So this PR has clean results. |
Resolves JP-3445
Closes #8027
This PR updates the Level-3 ASN rules for forming "tso3" type associations, so that NIRISS SOSS "dummy" exposures that have NINTS=1 are excluded from the association. They aren't desired to be part of the level-3 processing and cause an abort in the tso3 pipeline if they appear in the ASN.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR