Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3534 update to Sky Match docs #8356

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jemorrison
Copy link
Collaborator

@jemorrison jemorrison commented Mar 13, 2024

Resolves JP-3534

Closes #8269

This PR addresses corrects the spelling of the parameter options 'usigma' and 'lsigma'.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@jemorrison jemorrison requested a review from a team as a code owner March 13, 2024 16:39
@jemorrison jemorrison added this to the Build 10.2 milestone Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (4cc0ac1) to head (d75c5c4).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8356      +/-   ##
==========================================
+ Coverage   75.15%   75.35%   +0.20%     
==========================================
  Files         470      474       +4     
  Lines       38604    38944     +340     
==========================================
+ Hits        29014    29348     +334     
- Misses       9590     9596       +6     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.07%) ⬇️ Carriedforward from 4cc0ac1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jemorrison jemorrison changed the title JP-3534 update to Sky Match JP-3534 update to Sky Match docs Mar 14, 2024
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro merged commit 0671c7b into spacetelescope:master Mar 14, 2024
29 checks passed
@jemorrison jemorrison deleted the doc_updates branch November 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skymatch doc gives wrong parameter names
2 participants