-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3560: Updating CHARGELOSS Flagging #8336
Conversation
…Updated tests to satisfy this new flagging pattern.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8336 +/- ##
==========================================
+ Coverage 75.15% 75.27% +0.11%
==========================================
Files 470 474 +4
Lines 38604 39112 +508
==========================================
+ Hits 29014 29441 +427
- Misses 9590 9671 +81
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression test run shows a bunch of unrelated differences in NIRSpec results due to a recent CRDS ref file update, as well as the expected differences in NIRISS tests. So that all looks OK.
Resolves JP-3560
Closes #8331
This PR addresses CHARGELOSS flagging. The original implementation assumed an integration ramp that has a group above the CHARGELOSS threshold will have all remaining groups in the ramp above the CHARGELOSS threshold, so will also get the CHARGELOSS flag. This is not true. Additionally, the charge migration step flags nearest neighbors, the four pixels to the north, south, east, and west, with CHARGELOSS in the groups flagged in the ramp of interest. All subsequent groups in nearest neighbors also need to be flagged with CHARGELOSS and DO_NOT_USE.
The charge migration step has been changed to find the first group in an integration ramp that is above the CHARGELOSS threshold and not flagged as DO_NOT_USE, then it flags that group and all subsequent groups in the ramp with CHARGELOSS and DO_NOT_USE. The charge migration step also flags nearest neighbors in the same groups.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR