Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test specific log formatting for spec #8317

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jdavies-st
Copy link
Collaborator

This PR modifies a single test which expect a specific format for the logging of the step spec. Since we are changing the format in spacetelescope/stpipe#140, this test will fail. Instead, we just test for the new parameter being set in spec. Same test, less fragile. No runtime code changed.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro merged commit 08eda6e into spacetelescope:master Feb 29, 2024
26 checks passed
@jdavies-st jdavies-st deleted the log-readable-step-pars branch February 29, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants