-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3483: fix atoca failures due to sparse matrix solver #8273
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8273 +/- ##
==========================================
- Coverage 75.15% 75.14% -0.02%
==========================================
Files 470 470
Lines 38604 38611 +7
==========================================
Hits 29013 29013
- Misses 9591 9598 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One python version issue, I'm testing the regressions locally on py3.9 but I think my suggestion should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, other than the issue with having it work with py 3.9.
@emolter Need to resolve conflicts so that the CI tests can run. At that point another regtest run would be good. |
New Jenkins regression tests are here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves JP-3483
Closes #8110
This PR addresses a bug where the ATOCA algorithm's matrix solver would sometimes fail on good data, likely because the approximations in spsolve were inappropriate. The fix allows the code to try using a least-squares solver instead when these failures occur.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR
Jenkins run here. I don't think the failures have anything to do with this change.