-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3532: MRS 1d residual fringe treatment of negative values #8261
JP-3532: MRS 1d residual fringe treatment of negative values #8261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8261 +/- ##
==========================================
+ Coverage 75.18% 77.37% +2.18%
==========================================
Files 470 451 -19
Lines 38549 35270 -3279
==========================================
- Hits 28983 27290 -1693
+ Misses 9566 7980 -1586
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
regression tests started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1193 |
Regtest results are fine. 2 benign (unrelated) failures. |
Resolves JP-3532 by properly masking zero or negative-valued spectra instead of only zero-valued spectra.
Closes #8260
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR