Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3513: Remove warning about inaccurate errors #8258

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Feb 2, 2024

Resolves JP-3513

Closes #8204

This PR addresses removal of unnecessary warning when weight_type is set to 'exptime':
"Use of EXPTIME weighting will result in incorrect propagated errors in the resampled product". Errors are propagated identically for the 'exptime' and 'ivm' weight options.

The message is benign, but it has been asked about in helpdesk questions, and might unnecessarily deter users from using 'exptime' weights in place of 'ivm'.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner February 2, 2024 15:43
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65%. Comparing base (4179c09) to head (969cfd9).
Report is 321 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8258       +/-   ##
===========================================
+ Coverage   57.97%   75.65%   +17.67%     
===========================================
  Files         387      477       +90     
  Lines       38830    39651      +821     
===========================================
+ Hits        22513    29998     +7485     
+ Misses      16317     9653     -6664     
Flag Coverage Δ *Carryforward flag
nightly 77.66% <ø> (?) Carriedforward from 7d15aaf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing would make this PR perfect: set default weight to exptime, especially given that #7563 still hasn't been approved.

@hbushouse
Copy link
Collaborator

This should not be merged until there's consensus as to whether the warning message is accurate (i.e. I don't think it's benign, as has been suggested).

@melanieclarke
Copy link
Collaborator

@hbushouse @drlaw1558 - can this one be merged, now that error propagation for exptime and ivm weights are handled self-consistently (#8437)?

@drlaw1558
Copy link
Collaborator

@melanieclarke Seems reasonable to me as the entire point of all of that work was to fix the error propagation! @hbushouse 's call though.

@hbushouse hbushouse added this to the Build 11.0 milestone Jun 6, 2024
@hbushouse
Copy link
Collaborator

One more thing would make this PR perfect: set default weight to exptime, especially given that #7563 still hasn't been approved.

That's going to be done via the use of parameter reference files for the resample/resample_spec steps, where each instrument/mode will choose to set the default to 'exptime' if they want. There are still one or more modes where 'ivm' seems to be preferred.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are straight-forward enough and only involve log messages, so I don't see the need for a regression test run.

@hbushouse hbushouse merged commit e1b66cc into spacetelescope:master Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warning about inaccurate errors
6 participants