JP-3238: Include dispersion factor in PHOTOM correction for NRC grism #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the dispersion had been factored out of the absolute calibration because the dispersion varies with position and wavelength. This code puts that factor back in dividing the per-pixel conversion factors by the dispersion in Angstrom/pixel
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8207 +/- ##
==========================================
- Coverage 75.25% 75.25% -0.01%
==========================================
Files 470 470
Lines 38470 38495 +25
==========================================
+ Hits 28950 28968 +18
- Misses 9520 9527 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hbushouse
reviewed
Jan 22, 2024
|
Is there a regression test run from earlier that has these changes applied? If so, can you provide the link here? |
|
Link to developer regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1139/ |
hbushouse
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3238
Closes #7659
Added code to take acount of the fact that for NRC WFSS and TSGRISM datathe dispersion had been factored out of the absolute calibration because the dispersion varies with position and wavelength. This code puts that factor back in dividing the per-pixel conversion factors by the dispersion in Angstrom/pixel
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR