-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3510: Use all groups to flag bad IRS2 reference pixels #8197
JP-3510: Use all groups to flag bad IRS2 reference pixels #8197
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8197 +/- ##
==========================================
- Coverage 75.25% 75.25% -0.01%
==========================================
Files 470 470
Lines 38435 38466 +31
==========================================
+ Hits 28923 28946 +23
- Misses 9512 9520 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look fine. Just a couple minor comments.
Have you done a regression test run or do you not have permission to set those up on our Jenkins server? |
fd8820e
to
d159f51
Compare
@hbushouse - I have permission to see regression tests but not launch them. |
Regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1164 |
Regression test results look good. Several tests involving NIRSpec IRS2 data that show expected differences starting at the refpix step, as well as several unrelated differences due to other recent mergers into the master branch. |
Resolves JP-3510
Closes #8195
This PR improves on-the-fly bad reference pixel flagging by using all groups from all integrations to compile mean and standard deviation statistics. This should catch reference pixels that are intermittently bad and happened to be okay in the last group.
Additionally, this PR moves the flagging outside of the IRS2 correction method, so that it can be applied before any other reference pixel handling is done, and updates the pixel replacement method for both newly flagged bad pixels and known bad pixels. Replacement values come from the nearest reference groups, respecting parity if possible; 0.0 is used as a replacement value only as a last resort.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR