-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3248: MIRI Subarrays 390 Hz EMI bug fix #8147
Conversation
running reg tests at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1107/ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8147 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 470 470
Lines 38421 38430 +9
=======================================
+ Hits 28909 28916 +7
- Misses 9512 9514 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates and CI test results look good. Progress so far on regtests also looks good. Will reserve final approval until regtests finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regtest result is clean.
Resolves JP-3248
Closes #
This PR addresses emicorr crashing with readpatt values other than FASTR1 or SLOWR1.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR