Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3248: MIRI Subarrays 390 Hz EMI bug fix #8147

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Dec 18, 2023

Resolves JP-3248

Closes #

This PR addresses emicorr crashing with readpatt values other than FASTR1 or SLOWR1.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero
Copy link
Contributor Author

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (39d0e3f) 75.24% compared to head (bb8dc0c) 75.24%.

Files Patch % Lines
jwst/emicorr/emicorr.py 77.77% 4 Missing ⚠️
jwst/emicorr/emicorr_step.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8147   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files         470      470           
  Lines       38421    38430    +9     
=======================================
+ Hits        28909    28916    +7     
- Misses       9512     9514    +2     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 39d0e3f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.1 milestone Dec 18, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates and CI test results look good. Progress so far on regtests also looks good. Will reserve final approval until regtests finish.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regtest result is clean.

@hbushouse hbushouse changed the title JP-3248: MIRI Subarrays 390 Hz EMI JP-3248: MIRI Subarrays 390 Hz EMI bug fix Dec 19, 2023
@hbushouse hbushouse merged commit c2b3de4 into spacetelescope:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants