-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits #8081
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8081 +/- ##
==========================================
- Coverage 75.95% 75.93% -0.03%
==========================================
Files 459 459
Lines 37597 37608 +11
==========================================
Hits 28557 28557
- Misses 9040 9051 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The regrets ran successfully, though there are differences with the truth files, results are here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1055/#showFailuresLink |
Yes, those failures are unrelated (due to a recent ref file update). I wouldn't expect any changes in output from this PR, since it involves a user-specified input param. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Resolves JP-3223
Closes #7865
This PR addresses a crash of Spec2 when the parameter slit_name was provided as integer for MOS data. The pipeline now expects a string for this value, and the extract_2d code will make the corresponding value type conversions to make sure that both values in the comparison are the same type.
The documentation was modified to explain that for MOS data the value is expected as a string, e.g. slit_name='67'
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR