Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits #8081

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Nov 20, 2023

Resolves JP-3223

Closes #7865

This PR addresses a crash of Spec2 when the parameter slit_name was provided as integer for MOS data. The pipeline now expects a string for this value, and the extract_2d code will make the corresponding value type conversions to make sure that both values in the comparison are the same type.
The documentation was modified to explain that for MOS data the value is expected as a string, e.g. slit_name='67'

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5b63bda) 75.95% compared to head (cb327aa) 75.93%.

Files Patch % Lines
jwst/extract_2d/nirspec.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8081      +/-   ##
==========================================
- Coverage   75.95%   75.93%   -0.03%     
==========================================
  Files         459      459              
  Lines       37597    37608      +11     
==========================================
  Hits        28557    28557              
- Misses       9040     9051      +11     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (+<0.01%) ⬆️ Carriedforward from 47f8771

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penaguerrero
Copy link
Contributor Author

The regrets ran successfully, though there are differences with the truth files, results are here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1055/#showFailuresLink

@penaguerrero penaguerrero changed the title WIP: JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits Nov 21, 2023
@hbushouse hbushouse modified the milestones: Build 10.0.1, Build 10.1 Nov 21, 2023
@hbushouse
Copy link
Collaborator

The regrets ran successfully, though there are differences with the truth files, results are here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1055/#showFailuresLink

Yes, those failures are unrelated (due to a recent ref file update). I wouldn't expect any changes in output from this PR, since it involves a user-specified input param.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits
2 participants