JP-3466 Remove the CRDS PUB notices througout the documentation #8075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8075 +/- ##
=======================================
Coverage 75.95% 75.95%
=======================================
Files 459 459
Lines 37592 37592
=======================================
Hits 28552 28552
Misses 9040 9040
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hbushouse
approved these changes
Nov 15, 2023
|
Regtest failures are due to updated NIRSpec ref file. All looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3466
This PR removes all the in-line notifications about the CRDS PUB server. The server has not been available for over a year; there is no more reason for the in-your-face notifications.
However, for historical and the one potential user that may still have used it, the notification notice itself has been left in the index, though moved to the last position.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionupdated or added relevant testsHow to run regression tests on a PR