Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase asdf upper pin #8018

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 23, 2023

asdf 3.0 is compatible with jwst and is released on pypi and conda forge

This PR increases the asdf upper pin to 4 as asdf follows semantic versioning and all 3.x releases will be backwards compatible.

Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1014/

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram
Copy link
Collaborator Author

macos CI failure addressed in: #8013
devdeps CI failure addressed in: #8014
sdpdeps CI failure exists on main branch

@braingram braingram marked this pull request as ready for review October 23, 2023 22:01
@braingram braingram requested a review from a team as a code owner October 23, 2023 22:01
@hbushouse hbushouse merged commit 59c853c into spacetelescope:master Oct 24, 2023
@braingram braingram deleted the increase_asdf_pin branch October 24, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants