Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3424 Extend engineering coverage time for guiding modes #7966

Merged
merged 9 commits into from
Sep 25, 2023
Merged

JP-3424 Extend engineering coverage time for guiding modes #7966

merged 9 commits into from
Sep 25, 2023

Conversation

stscieisenhamer
Copy link
Collaborator

@stscieisenhamer stscieisenhamer commented Sep 21, 2023 •
edited by hbushouse
Loading

Resolves JP-3424

Closes #7963

This PR addresses an issue discovered during Build 10.0 integration with WCS determination in set_telescope_pointing. A new algorithm for the various guider products has been implemented, which require more engineering coverage than science exposures. Turns out that not enough leeway being given. This PR extends the coverage time to use when retrieving engineering data.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@stscieisenhamer stscieisenhamer added bug sdp Bugs arising due to SDP testing set_telescope_pointing labels Sep 21, 2023
@stscieisenhamer stscieisenhamer added this to the Build 10.0 milestone Sep 21, 2023
@stscieisenhamer stscieisenhamer requested a review from a team as a code owner September 21, 2023 21:05
@stscieisenhamer stscieisenhamer self-assigned this Sep 21, 2023
tapastro
tapastro approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@tapastro tapastro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as my extremely limited knowledge of STP goes, this looks good to me. 🙃

Is there regtest coverage of this?

@stscieisenhamer
Copy link
Collaborator Author

Regression test

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage is 13.63% of modified lines.

Files Changed Coverage
jwst/lib/set_telescope_pointing.py 13.63%

📢 Thoughts on this report? Let us know!.

hbushouse
hbushouse approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks find, but the tests are failing.

@stscieisenhamer stscieisenhamer marked this pull request as draft September 22, 2023 12:57
@stscieisenhamer
Copy link
Collaborator Author

Yet Another Regression Run. This one is limited to the pointing and engineering tests, but now they do all pass.

@stscieisenhamer stscieisenhamer marked this pull request as ready for review September 25, 2023 15:56
@stscieisenhamer stscieisenhamer merged commit 25de3eb into spacetelescope:master Sep 25, 2023
@stscijgbot-jp stscijgbot-jp mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees

@stscieisenhamer stscieisenhamer

Labels
bug sdp Bugs arising due to SDP testing set_telescope_pointing testing
Projects
None yet
Milestone
Build 10.0
Development

Successfully merging this pull request may close these issues.

STP: Guide star determination fails when using actual engineering db
3 participants
@stscieisenhamer @tapastro @hbushouse