Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3343: Add bounding_box to imaging WCS objects without one #7809

Merged
merged 5 commits into from
Aug 19, 2023
Merged

JP-3343: Add bounding_box to imaging WCS objects without one #7809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
154fbf8
regtest experiment
tapastro Aug 11, 2023
11f6f17
changelog
tapastro Aug 15, 2023
c3168b1
avoid duplicate bbox generation
tapastro Aug 16, 2023
7d546c5
generalize changelog entry
tapastro Aug 16, 2023
4f9a351
revert to first method
tapastro Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ assign_wcs

- Use isinstance instead of comparison with a type for lamp_mode inspection [#7801]

- Save bounding box to imaging WCS matching the shape of the data, for datamodels
without a defined bounding box. [#7809]

associations
------------

Expand Down
1 change: 1 addition & 0 deletions jwst/assign_wcs/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ def update_s_region_imaging(model):

if bbox is None:
bbox = wcs_bbox_from_shape(model.data.shape)
model.meta.wcs.bounding_box = bbox

# footprint is an array of shape (2, 4) as we
# are interested only in the footprint on the sky
Expand Down