-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add quick check for alternative engineering database test #7780
Conversation
76dbbf4
to
3579621
Compare
@stscieisenhamer as the author of #3022 do you foresee issues with reintroducing the decorator to skip this test when the host does not respond? If so, are there alternatives you might suggest for allowing this test to skip without waiting for the timeout. Perhaps skipping it for github CI runs (although this also impacts local runs when not on the vpn) or reducing the timeout? |
e9ed98f
to
1170fa9
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7780 +/- ##
==========================================
+ Coverage 76.54% 76.59% +0.04%
==========================================
Files 456 456
Lines 36947 36963 +16
==========================================
+ Hits 28282 28310 +28
+ Misses 8665 8653 -12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1170fa9
to
aad4c6f
Compare
Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/831/ |
Closing and reopening to retrigger docs. |
Not sure why the docs are failing with:
@zacharyburnett Have you seen any error like this before? |
aad4c6f
to
e7914aa
Compare
The docs seem happy again. I'm going to chalk this up to readthedocs attempting to clone the repo before github was fully updated or something. |
Regression tests passed with no failures. Note that the modified test |
e7914aa
to
f007523
Compare
Thanks! I rebased this PR to grab the most recent changes. |
The test_environmental test when not run on the vpn will fail to contact the alternative engineering database server. This results in the test taking ~10 minutes waiting for a response before turning into a skip. This commit adds some lines of code that were removed in PR spacetelescope#3022 which changed the skip from a decorator to a pytest.skip when the exception/timeout occurs. This should allow the test to skip quickly when the host is not accessable (and instead skips in <1 second). The pytest.skip call during the except block is left to deal with cases when the host resolves but the url fails to resolve.
f007523
to
c8f202f
Compare
The test_environmental test when not run on the vpn will fail to contact the alternative engineering database server. This results in the test taking ~10 minutes waiting for a response before turning into a skip.
This commit adds some lines of code that were removed in PR #3022 which changed the skip from a decorator to a pytest.skip when the exception/timeout occurs. This should allow the test to skip quickly when the host is not accessable (and instead skips in <1 second). The pytest.skip call during the except block is left to deal with cases when the host resolves but the url fails to resolve.
As the alternative host appears unresponsive for github CI runs (which run tests in parallel with 2 workers) this should free up one of the workers that without this PR sits waiting for ~10 minutes. As a comparison, the python 3.9 tests for this recent PR took ~22 minutes whereas similar tests for this PR took ~16 minutes.
Resolves JP-nnnn
Closes #
This PR addresses ...
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR