JP-3321: NRS IRS2 refpix bad pixel updates #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7745 +/- ##
==========================================
- Coverage 76.54% 76.54% -0.01%
==========================================
Files 456 456
Lines 36939 36941 +2
==========================================
+ Hits 28275 28276 +1
- Misses 8664 8665 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
penaguerrero
changed the title
penaguerrero
force-pushed
the
irs2fix_take2
branch
2 times, most recently
from
97ef9e4 to
11b77f9
Compare
hbushouse
changed the title
hbushouse
reviewed
Aug 2, 2023
penaguerrero
force-pushed
the
irs2fix_take2
branch
from
e99fe7b to
8462fe8
Compare
|
ok, regression tests ran. The test shows very small differences expected due to the changes made. |
Please post a link to the regression test run, so that the results can be reviewed. |
|
regression test link: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/836/ |
stscieisenhamer
pushed a commit
to stscieisenhamer/jwst
that referenced
this pull request
Aug 11, 2023
Co-authored-by: Howard Bushouse <[email protected]>
mairanteodoro
pushed a commit
to mairanteodoro/jwst
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Howard Bushouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prompted by help desk ticket INC0191416. It is a minor improvement on the new implementation to fix the intermittently bad reference pixels.
Resolves JP-3321
Closes #7805
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR