-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses and references to deprecated jwst.datamodels.DataModel
#7607
Remove uses and references to deprecated jwst.datamodels.DataModel
#7607
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7607 +/- ##
==========================================
- Coverage 77.41% 77.40% -0.01%
==========================================
Files 455 455
Lines 36542 36542
==========================================
- Hits 28288 28287 -1
- Misses 8254 8255 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
37a39b8
to
7afd7e9
Compare
Regression tests running at: |
Regression tests passed with no errors. I'm not sure why the mac run on github took so long for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like most changes are just in doc strings and hence harmless.
Closes #7574
This PR removes use of the deprecated and soon to be removed
jwst.datamodels.DataModel
from:DataModel
which appear to either not reference a page or reference a broken page).Removing the uses here (and in crds: spacetelescope/crds#938) should allow us to remove the model from stdatamodels: spacetelescope/stdatamodels#171
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR