Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sphinx_astropy sphinx extension with pytest-doctestplus #6230

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

eslavich
Copy link
Collaborator

@eslavich eslavich commented Jul 22, 2021

Description

This PR attempts to resolve the doc build failure due to changes in sphinx_astropy 1.5.0.

Checklist

  • Tests

  • Documentation

  • Change log

  • Milestone

  • Label(s)

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #6230 (6f1ab0d) into master (d123c28) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6230      +/-   ##
==========================================
+ Coverage   77.69%   77.77%   +0.08%     
==========================================
  Files         402      402              
  Lines       34412    34422      +10     
==========================================
+ Hits        26736    26773      +37     
+ Misses       7676     7649      -27     
Flag Coverage Δ *Carryforward flag
nightly 77.69% <ø> (ø) Carriedforward from d123c28
unit 55.54% <ø> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/associations/lib/process_list.py 73.49% <0.00%> (-0.59%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/timeconversion/time_conversion.py 10.96% <0.00%> (-0.08%) ⬇️
jwst/datamodels/make_header.py 91.38% <0.00%> (+0.02%) ⬆️
jwst/associations/lib/product_utils.py 94.82% <0.00%> (+0.09%) ⬆️
jwst/associations/lib/constraint.py 93.65% <0.00%> (+0.37%) ⬆️
jwst/regtest/conftest.py 90.90% <0.00%> (+1.21%) ⬆️
jwst/wiimatch/match.py 67.30% <0.00%> (+1.92%) ⬆️
jwst/wiimatch/lsq_optimizer.py 88.42% <0.00%> (+5.26%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d123c28...6f1ab0d. Read the comment docs.

@eslavich eslavich requested review from jdavies-st and hbushouse July 22, 2021 16:15
@jdavies-st jdavies-st added this to the Build 7.9 milestone Jul 22, 2021
Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eslavich eslavich merged commit b85879e into spacetelescope:master Jul 22, 2021
@eslavich eslavich deleted the eslavich-drop-doctest-ext branch July 22, 2021 17:42
@jdavies-st jdavies-st mentioned this pull request Oct 5, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants