Revert removal of ramp_fit code to stcal #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.2.x #6119 +/- ##
==========================================
+ Coverage 77.15% 77.65% +0.50%
==========================================
Files 402 406 +4
Lines 34360 36128 +1768
==========================================
+ Hits 26509 28057 +1548
- Misses 7851 8071 +220
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
nden
approved these changes
Jun 4, 2021
kmacdonald-stsci
approved these changes
Jun 4, 2021
…ed to STCAL (spacetelescope#6010)" This reverts commit 5a9aaf8.
jdavies-st
force-pushed
the
revert-rampfit-to-stcal
branch
from
bad885a to
0564070
Compare
|
FYI @kmacdonald-stsci I'm just going to do the revert here on the release branch so only the release version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the removal of the ramp fitting code (to stcal). Specifically it reverts commits 85feb11 and 5a9aaf8 but retains the bugfix and test updates in bfe9d64 .
This also turns on the 2
ramp_fitmultiprocessing unit tests. To make sure that aspect of the code is no longer broken.Regression tests run on this branch here and pass.
https://plwishmaster.stsci.edu:8081/job/RT/job/jdavies-dev/251/
Note that the test failure is an intermittent one that @hbushouse warned me about that occasionally pops up in our regression tests due to cosmic variance.
Checklist