JP-2108 Asn_Lv2NRSLAMPSpectral: Allow msaspec only if msametfl is available. #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapastro
reviewed
May 27, 2021
| [ | ||
| Constraint( | ||
| [DMSAttrConstraint( | ||
| name='opmode', |
There was a problem hiding this comment.
So to put this logic in simple terms, this rule passes if either: the OPMODE is not MSASPEC - or - OPMODE is MSASPEC and MSAMETFL is present?
hbushouse
reviewed
May 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #6085 +/- ##
==========================================
+ Coverage 77.13% 77.19% +0.06%
==========================================
Files 402 402
Lines 34329 34523 +194
==========================================
+ Hits 26479 26650 +171
- Misses 7850 7873 +23
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
reviewed
May 27, 2021
hbushouse
approved these changes
May 28, 2021
AntoineDarveau
pushed a commit
to talensgj/jwst
that referenced
this pull request
Oct 26, 2021
…ilable. (spacetelescope#6085) * Asn_Lv2NRSLAMPSpectral: Allow msaspec only if msametfl is available. * update changelog * update changelog again [skip ci]
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
…ilable. (spacetelescope#6085) * Asn_Lv2NRSLAMPSpectral: Allow msaspec only if msametfl is available. * update changelog * update changelog again [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6084
Resolves JP-2108
Checklist