Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2067: Add units to combine1d product table #6082

Merged
merged 2 commits into from
May 27, 2021

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented May 27, 2021

Closes #6002

Resolves JP-2067

Description

This PR adds units to the CombinedSpecModel table output of the Combine1D step. Flux and SB units are checked from the input spectra, while wavelength units are set to um.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@tapastro tapastro added this to the Build 7.9 milestone May 27, 2021
@hbushouse hbushouse modified the milestones: Build 7.9, Build 7.8 May 27, 2021
@hbushouse
Copy link
Collaborator

Errors/differences in CI / SDP dependencies tests are due to use of updated NIRCam specwcs ref files (in latest context). Some assign_wcs tests need to have their truth values updated. Unrelated to this PR.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #6082 (b3bf8a2) into master (b77df8a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6082      +/-   ##
==========================================
+ Coverage   77.13%   77.16%   +0.03%     
==========================================
  Files         402      402              
  Lines       34321    34444     +123     
==========================================
+ Hits        26474    26580     +106     
- Misses       7847     7864      +17     
Flag Coverage Δ *Carryforward flag
nightly 77.13% <100.00%> (ø) Carriedforward from b77df8a
unit 55.19% <100.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/combine_1d/combine1d.py 89.46% <100.00%> (-0.40%) ⬇️
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/associations/lib/process_list.py 73.49% <0.00%> (-0.59%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/timeconversion/time_conversion.py 10.96% <0.00%> (-0.08%) ⬇️
jwst/datamodels/make_header.py 91.38% <0.00%> (+0.02%) ⬆️
jwst/associations/lib/product_utils.py 94.82% <0.00%> (+0.09%) ⬆️
jwst/regtest/conftest.py 90.96% <0.00%> (+1.20%) ⬆️
jwst/tso_photometry/tso_photometry_step.py 77.41% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77df8a...b3bf8a2. Read the comment docs.

@tapastro tapastro merged commit 4bd9e5a into spacetelescope:master May 27, 2021
@tapastro tapastro deleted the jp-2067-update-c1d-units branch May 27, 2021 17:31
AntoineDarveau pushed a commit to talensgj/jwst that referenced this pull request Oct 26, 2021
* add units to combine1d intermediate and final products

* changelog and CI restart
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
* add units to combine1d intermediate and final products

* changelog and CI restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set column units in combine_1d (c1d) products
3 participants