-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2067: Add units to combine1d product table #6082
JP-2067: Add units to combine1d product table #6082
Conversation
Errors/differences in CI / SDP dependencies tests are due to use of updated NIRCam specwcs ref files (in latest context). Some assign_wcs tests need to have their truth values updated. Unrelated to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #6082 +/- ##
==========================================
+ Coverage 77.13% 77.16% +0.03%
==========================================
Files 402 402
Lines 34321 34444 +123
==========================================
+ Hits 26474 26580 +106
- Misses 7847 7864 +17
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
* add units to combine1d intermediate and final products * changelog and CI restart
* add units to combine1d intermediate and final products * changelog and CI restart
Closes #6002
Resolves JP-2067
Description
This PR adds units to the CombinedSpecModel table output of the Combine1D step. Flux and SB units are checked from the input spectra, while wavelength units are set to um.
Checklist