Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-2106: Update keyword schema enum lists #6081

Merged
merged 4 commits into from
May 27, 2021
Merged

JP-2106: Update keyword schema enum lists #6081

merged 4 commits into from
May 27, 2021

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented May 26, 2021 •
edited
Loading

Closes #6078

Resolves JP-2106

Description
Update the enum lists for a few keywords to bring them into synch with what's in the KWD for B7.8

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@hbushouse hbushouse added datamodels keywords Anything related to FITS header keywords labels May 26, 2021
@hbushouse hbushouse added this to the Build 7.8 milestone May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #6081 (21835b1) into master (20d5bbb) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

❗ Current head 21835b1 differs from pull request most recent head 17737d4. Consider uploading reports for the commit 17737d4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6081      +/-   ##
==========================================
- Coverage   77.13%   76.99%   -0.15%     
==========================================
  Files         402      402              
  Lines       34329    34329              
==========================================
- Hits        26479    26430      -49     
- Misses       7850     7899      +49
Flag Coverage Δ *Carryforward flag
nightly 76.99% <66.66%> (-0.14%) ⬇️ Carriedforward from f39ee0a
unit 54.83% <66.66%> (-0.35%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/lib/set_telescope_pointing.py 89.49% <66.66%> (ø)
jwst/regtest/conftest.py 67.46% <0.00%> (-23.50%) ⬇️
jwst/regtest/regtestdata.py 82.06% <0.00%> (-3.14%) ⬇️
jwst/white_light/white_light.py 91.30% <0.00%> (-2.18%) ⬇️
jwst/tso_photometry/tso_photometry_step.py 75.80% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77df8a...17737d4. Read the comment docs.

@hbushouse hbushouse requested a review from tapastro May 27, 2021 12:40
tapastro
tapastro approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hbushouse
Copy link
Collaborator Author

Current CI failures are due to CRDS server being off-line for OS patching.

@hbushouse hbushouse merged commit f934522 into spacetelescope:master May 27, 2021
@hbushouse hbushouse deleted the jp-2106 branch May 27, 2021 14:10
@stscijgbot-jp stscijgbot-jp mentioned this pull request May 27, 2021
Closed
@hbushouse hbushouse mentioned this pull request May 28, 2021
Merged
5 tasks
AntoineDarveau pushed a commit to talensgj/jwst that referenced this pull request Oct 26, 2021
@hbushouse @AntoineDarveau
JP-2106: Update keyword schema enum lists (spacetelescope#6081)
495a902 
* JP-2106: Update keyword schema enum lists

* Add change log entry and remove errant quote marks

* Update set_telescope_pointing for new attribute name
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
@hbushouse @loicalbert
JP-2106: Update keyword schema enum lists (spacetelescope#6081)
1c5e032 
* JP-2106: Update keyword schema enum lists

* Add change log entry and remove errant quote marks

* Update set_telescope_pointing for new attribute name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@tapastro tapastro tapastro approved these changes

Assignees
No one assigned
Labels
datamodels keywords Anything related to FITS header keywords
Projects
None yet
Milestone
Build 7.8
Development

Successfully merging this pull request may close these issues.

Update keyword enum lists in datamodels schemas
3 participants
@hbushouse @stscieisenhamer @tapastro