-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2066: Add srctype to Combine1D headers #6079
JP-2066: Add srctype to Combine1D headers #6079
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6079 +/- ##
==========================================
+ Coverage 76.99% 77.03% +0.03%
==========================================
Files 402 402
Lines 34329 34406 +77
==========================================
+ Hits 26431 26503 +72
- Misses 7898 7903 +5
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
I'll be honest that I never really looked into why there are a few different CI test runs - any explanation why the SDP deps version failed here? I poked around a bit, and it seems like things might be out of date in that run, but I don't fully grok what's going on here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unfortunately the previous CI results seem to have disappeared, as a result of the latest commit using [skip ci] |
Under the checks tab, you should be able to select the checks of the previous commit with a dropdown - it failed one of them. |
Hmmm, same set of tests failed in my PR for the CI run using SDP dependencies. No clue. |
CI failure for "SDP dependencies" test is due to use of the latest CRDS context that has a bad NIRCam specwcs rmap in it. Redcat folks are fixing. So you can ignore. |
* start adding source_type * push source_type to c1d * [skip ci] changelog
* start adding source_type * push source_type to c1d * [skip ci] changelog
Closes #6000 🎉
Resolves JP-2066
Description
This PR adds source_type information to combine1d extensions of c1d.fits files, pulled from the x1d inputs to the Combine1D step.
Checklist