JP-1950: Update ramp fit unit tests #6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmggh
approved these changes
May 18, 2021
|
Yes. I should have made that more clear. The slope estimate change done in this PR effects many calculations. The regression test truth files need to be adjusted to account for this change. |
jdavies-st
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6038 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 401 401
Lines 34307 34307
=======================================
Hits 26454 26454
Misses 7853 7853
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
jdavies-st
reviewed
May 20, 2021
jdavies-st
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3879
Resolves JP-1950
Description
This PR addresses unit tests for ramp fitting. A bug fix was found in the computation of the median first differences of a pixel ramp. Correcting this bug means revising unit and regression tests. The bug fix effected two unit test cases. These tests have been updated to account for the bug fix. Work needs to be done to correct regression tests.
Bugfix in spacetelescope/stcal#12
Checklist