-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2076 moved wrap_ra to assign_wcs #6026
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6026 +/- ##
==========================================
- Coverage 77.80% 76.86% -0.94%
==========================================
Files 399 405 +6
Lines 35354 37186 +1832
==========================================
+ Hits 27506 28582 +1076
- Misses 7848 8604 +756
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Any comments from our WCS experts? @nden
This PR fixes a bug in the s_region value calculated in assign_wcs for data at ra = 0 (border)
The wrap_ra routine in cube_build was moved to assign_wcs. The import statement in resample_spec to use wrap_ra is not moved to point to assign_wcs.util
This work also supports JP-364 - improving the speed of cube_build by using the values in s_region
Closes #6019
Resolves JP-2076