Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2076 moved wrap_ra to assign_wcs #6026

Merged
merged 4 commits into from
May 14, 2021

Conversation

jemorrison
Copy link
Collaborator

@jemorrison jemorrison commented May 14, 2021

This PR fixes a bug in the s_region value calculated in assign_wcs for data at ra = 0 (border)
The wrap_ra routine in cube_build was moved to assign_wcs. The import statement in resample_spec to use wrap_ra is not moved to point to assign_wcs.util
This work also supports JP-364 - improving the speed of cube_build by using the values in s_region

Closes #6019
Resolves JP-2076

@jemorrison jemorrison requested review from jdavies-st and nden May 14, 2021 13:35
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #6026 (12a8e06) into master (23a76da) will decrease coverage by 0.93%.
The diff coverage is 77.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6026      +/-   ##
==========================================
- Coverage   77.80%   76.86%   -0.94%     
==========================================
  Files         399      405       +6     
  Lines       35354    37186    +1832     
==========================================
+ Hits        27506    28582    +1076     
- Misses       7848     8604     +756     
Flag Coverage Δ *Carryforward flag
nightly 77.80% <100.00%> (ø) Carriedforward from 7e1e59d
unit 56.65% <63.41%> (-0.22%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/cube_build/cube_build_wcs_util.py 34.18% <60.00%> (+0.36%) ⬆️
jwst/assign_wcs/util.py 78.36% <82.75%> (-2.46%) ⬇️
jwst/cube_build/ifu_cube.py 60.64% <100.00%> (-12.06%) ⬇️
jwst/resample/resample_spec.py 96.36% <100.00%> (ø)
jwst/pipeline/calwebb_spec2.py 76.74% <0.00%> (-19.32%) ⬇️
jwst/ramp_fitting/utils.py 92.40% <0.00%> (-1.85%) ⬇️
jwst/source_catalog/source_catalog_step.py 89.06% <0.00%> (-1.27%) ⬇️
jwst/step.py 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a76da...12a8e06. Read the comment docs.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Any comments from our WCS experts? @nden

@hbushouse hbushouse merged commit a727b1a into spacetelescope:master May 14, 2021
@jemorrison jemorrison deleted the wrap_ra branch November 4, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move cube_build.wrap_ra to assign_wcs.util.py
3 participants