Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-479: Move ramp fit code from JWST to STCAL. #6023

Merged
merged 3 commits into from
May 18, 2021
Merged

AL-479: Move ramp fit code from JWST to STCAL. #6023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
698018e
Removed ramp fit code from JWST and moved it to STCAL. Tests are pas…
kmacdonald-stsci May 12, 2021
907ffc8
Added changes to the change log and removed unnecessary comments.
kmacdonald-stsci May 13, 2021
523ef17
temporarily point to stcal/main
nden May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ ramp_fitting

- Refactoring ramp fit code in preparation for moving code to STCAL. [#6010]

- Moved ramp fit code to STCAL. [#6023]

refpix
------

Expand Down
1,184 changes: 0 additions & 1,184 deletions jwst/ramp_fitting/gls_fit.py
View file
Open in desktop

This file was deleted.

3,440 changes: 0 additions & 3,440 deletions jwst/ramp_fitting/ols_fit.py
View file
Open in desktop

This file was deleted.

104 changes: 0 additions & 104 deletions jwst/ramp_fitting/ramp_fit.py
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions jwst/ramp_fitting/ramp_fit_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
from ..stpipe import Step
from .. import datamodels

from . import ramp_fit
# from stcal.ramp_fitting import ramp_fit
from stcal.ramp_fitting import ramp_fit

from ..lib import reffile_utils # TODO remove
from ..lib import pipe_utils
Expand Down
6 changes: 2 additions & 4 deletions jwst/ramp_fitting/tests/test_ramp_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import pytest
import numpy as np

from jwst.ramp_fitting.ramp_fit import ramp_fit
from jwst.ramp_fitting.ols_fit import calc_num_seg
# from stcal.ramp_fitting.ramp_fit import ramp_fit
# from stcal.ramp_fitting.ols_fit import calc_num_seg
from stcal.ramp_fitting.ramp_fit import ramp_fit
from stcal.ramp_fitting.ols_fit import calc_num_seg

from jwst.datamodels import dqflags
from jwst.datamodels import RampModel
Expand Down
3 changes: 1 addition & 2 deletions jwst/ramp_fitting/tests/test_ramp_fit_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import numpy as np
import numpy.testing as npt

from jwst.ramp_fitting.ramp_fit import ramp_fit
# from stcal.ramp_fitting.ramp_fit import ramp_fit
from stcal.ramp_fitting.ramp_fit import ramp_fit

from jwst.datamodels import RampModel
from jwst.datamodels import GainModel, ReadnoiseModel
Expand Down
Loading